Skip to content

Conversation

LeSeulArtichaut
Copy link
Contributor

Experiment to see if/how much this helps negate the perf impact of #85273.
r? @ghost

@lqd
Copy link
Member

lqd commented May 26, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 26, 2021
@bors
Copy link
Collaborator

bors commented May 26, 2021

⌛ Trying commit fdc15ef with merge fcfe8b35f9c1aa6f1b1a4dd0f248fc2b7fa16981...

@bors
Copy link
Collaborator

bors commented May 26, 2021

☀️ Try build successful - checks-actions
Build commit: fcfe8b35f9c1aa6f1b1a4dd0f248fc2b7fa16981 (fcfe8b35f9c1aa6f1b1a4dd0f248fc2b7fa16981)

@rust-timer
Copy link
Collaborator

Queued fcfe8b35f9c1aa6f1b1a4dd0f248fc2b7fa16981 with parent 9a700d2, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (fcfe8b35f9c1aa6f1b1a4dd0f248fc2b7fa16981): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 26, 2021
@LeSeulArtichaut LeSeulArtichaut marked this pull request as ready for review May 27, 2021 00:20
@LeSeulArtichaut
Copy link
Contributor Author

r? @nikomatsakis

@rust-timer

This comment has been minimized.

@nikomatsakis
Copy link
Contributor

r=me with a comment as @michaelwoerister suggested

@nikomatsakis
Copy link
Contributor

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented May 27, 2021

📌 Commit 9385be7 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 27, 2021
@bors
Copy link
Collaborator

bors commented May 27, 2021

⌛ Testing commit 9385be7 with merge d854c3c...

@bors
Copy link
Collaborator

bors commented May 27, 2021

☀️ Test successful - checks-actions
Approved by: nikomatsakis
Pushing d854c3c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 27, 2021
@bors bors merged commit d854c3c into rust-lang:master May 27, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 27, 2021
@LeSeulArtichaut LeSeulArtichaut deleted the thir-no-hash branch May 27, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants